fix: r.v as io.Closer should always close

octohelm · Jan 11, 2025 · 1a0a06c · 1a0a06c
1 parent e7e7b35
commit 1a0a06c
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/pkg/courierhttp/payload.go b/pkg/courierhttp/payload.go
@@ -201,6 +201,10 @@ func (r *response[T]) Meta() courier.Metadata {
 
 func (r *response[T]) WriteResponse(ctx context.Context, rw http.ResponseWriter, req RequestInfo) (finalErr error) {
 	defer func() {
+		if x, ok := r.v.(io.Closer); ok {
+			// close again to avoid some leak issue
+			_ = x.Close()
+		}
 		r.v = nil
 		if finalErr != nil {
 			logr.FromContext(ctx).Error(finalErr)