fix(deps): bump aggregate-error from 3.0.1 to 3.1.0 (#216)

* build(deps): bump aggregate-error from 3.0.1 to 3.1.0 Bumps [aggregate-error](https://github.com/sindresorhus/aggregate-error) from 3.0.1 to 3.1.0. - [Release notes](https://github.com/sindresorhus/aggregate-error/releases) - [Commits](sindresorhus/aggregate-error@v3.0.1...v3.1.0) Signed-off-by: dependabot[bot] <[email protected]> * build(package): audit fix * refactor: remove internal type definition for AggregateError Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Gregor Martynus <[email protected]>
octokit · Aug 24, 2020 · b359fde · b359fde
1 parent 324ce60
commit b359fde
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 30 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/event-handler/receive.ts b/src/event-handler/receive.ts
@@ -33,13 +33,10 @@ export function receiverHandle(state: State, event: WebhookEvent) {
   const errorHandlers = state.hooks.error || [];
 
   if (event instanceof Error) {
-    const error = Object.assign(
-      new AggregateError([event]) as WebhookEventHandlerError,
-      {
-        event,
-        errors: [event],
-      }
-    );
+    const error = Object.assign(new AggregateError([event]), {
+      event,
+      errors: [event],
+    });
 
     errorHandlers.forEach((handler) => wrapErrorHandler(handler, error));
     return Promise.reject(error);

diff --git a/src/types.ts b/src/types.ts
@@ -1,6 +1,8 @@
-import { RequestError } from "@octokit/request-error";
+import type AggregateError from "aggregate-error";
+import type { RequestError } from "@octokit/request-error";
+
+import type { EventNames } from "./generated/event-names";
 
-import { EventNames } from "./generated/event-names";
 export interface WebhookEvent<T = any> {
   id: string;
   name: EventNames.StringNames;
@@ -45,18 +47,3 @@ export interface WebhookEventHandlerError extends AggregateError<WebhookError> {
    */
   errors: WebhookError[];
 }
-
-// temporary using a custom AggregateError type.
-// Replace with `import AggregateError from "aggregate-error"` once
-// https://github.com/gr2m/aggregate-error/pull/1 is merged or resolved
-
-/**
-Create an error from multiple errors.
-*/
-declare class AggregateError<T extends Error = Error> extends Error
-  implements Iterable<T> {
-  readonly name: "AggregateError";
-  constructor(errors: ReadonlyArray<T | { [key: string]: any } | string>);
-
-  [Symbol.iterator](): IterableIterator<T>;
-}