Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: contribution: refactor diff command #70

Open
kamilsk opened this issue Jul 23, 2022 · 0 comments
Open

github: contribution: refactor diff command #70

kamilsk opened this issue Jul 23, 2022 · 0 comments
Assignees
Labels
effort: medium An issue has a medium complexity. impact: medium An issue has medium impact. scope: code An issue related to source code. scope: docs An issue related to documentation. scope: test An issue related to tests. type: improvement A new improvement proposal.
Milestone

Comments

@kamilsk
Copy link
Member

kamilsk commented Jul 23, 2022

Motivation: it contains invalid logic and showed problem after refactoring after 1522818.

$ maintainer github contribution diff --base=/tmp/snap.01.2013.json --head=/tmp/snap.02.2013.json
 Day / Week                  #46             #48             #49           #50    
---------------------- --------------- --------------- --------------- -----------
 Sunday                       -               -               -             -     
 Monday                       -               -               -             -     
 Tuesday                      -               -               -             -     
 Wednesday                   -4               -              -1             -     
 Thursday                     -               -               -            -1     
 Friday                       -              -2               -             -     
 Saturday                     -               -               -             -     
---------------------- --------------- --------------- --------------- -----------
 The diff between head{"/tmp/snap.02.2013.json"} → base{"/tmp/snap.01.2013.json"}

must be + instead of -.

Also, --base=/tmp/snap.01.2013.json --head=/tmp/snap.02.2013.json should be args, not params. See diff as reference, https://linuxize.com/post/diff-command-in-linux/.

@kamilsk kamilsk added kind: improvement scope: code An issue related to source code. labels Jul 23, 2022
@kamilsk kamilsk added this to the v0.1.x milestone Jul 23, 2022
@kamilsk kamilsk self-assigned this Jul 23, 2022
@kamilsk kamilsk moved this to Backlog in 🏗 Platform Jul 23, 2022
@kamilsk kamilsk added scope: test An issue related to tests. scope: docs An issue related to documentation. labels Jul 23, 2022
@kamilsk kamilsk added invalid This doesn't seem right. and removed invalid This doesn't seem right. labels Oct 19, 2022
@kamilsk kamilsk added type: improvement A new improvement proposal. impact: medium An issue has medium impact. effort: medium An issue has a medium complexity. labels Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: medium An issue has a medium complexity. impact: medium An issue has medium impact. scope: code An issue related to source code. scope: docs An issue related to documentation. scope: test An issue related to tests. type: improvement A new improvement proposal.
Projects
Status: Backlog
Development

No branches or pull requests

1 participant