Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obuilder's Dockerfiles should not continue to blank lines #65

Closed
dra27 opened this issue Mar 22, 2021 · 2 comments
Closed

Obuilder's Dockerfiles should not continue to blank lines #65

dra27 opened this issue Mar 22, 2021 · 2 comments

Comments

@dra27
Copy link
Contributor

dra27 commented Mar 22, 2021

Merely picking a recent build from opam-repo-ci, the Dockerfile includes a continuation to a blank line which generates a warning from docker build.

An easy fix for that one is probably just to trim the string - and possibly to reduce (\r?\n) to a single \r?\n?

@talex5
Copy link
Contributor

talex5 commented Mar 22, 2021

Well, it's because opam-repo-ci gives it a command with a blank line at the end. OBuilder's behaviour seems reasonable to me, but Docker's doesn't. It seems to ignore the blank line and act as if the continuation applies to the line after that!

Perhaps it should be an error to attempt to convert such a command to a Dockerfile?

@talex5
Copy link
Contributor

talex5 commented Mar 22, 2021

Closing as I think it's just a special-case of #66 (Dockerfile can't handle newlines in general).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants