Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no docs for odoc :-( #170

Open
jonludlam opened this issue Feb 16, 2024 · 5 comments
Open

no docs for odoc :-( #170

jonludlam opened this issue Feb 16, 2024 · 5 comments

Comments

@jonludlam
Copy link
Contributor

There are no docs for odoc on ocaml.org - this appears to be a problem with the solver - https://docs.ci.ocaml.org/package/odoc.2.4.1 shows

Error from solver: Bad frame from worker: time="1.36" len="0.0"
@tmcgilchrist
Copy link
Member

That is an error from the solver in docs, rather than failing to find a solution for odoc. Reported under ocurrent/solver-service#61.
The fix would either need to be ported across to the copy of solver-service in this project or modify docs-ci to use the solver-service over CapnProto.

@jonludlam
Copy link
Contributor Author

I'm not sure it's the same cause, because every single version of odoc is failing with the same error, and ocurrent/solver-service#61 looks less reproducible.

@moyodiallo
Copy link
Contributor

moyodiallo commented Apr 2, 2024

I'm not sure it's the same cause, because every single version of odoc is failing with the same error, and ocurrent/solver-service#61 looks less reproducible.

Indeed, this is less reproducible, it was known when scaling solver-service which put pressure on the solver. Lot of issues pop up and we solved them. The solver was stable and could take more workers, it was successfully tested with 128 workers.

The solver of ocaml-docs-ci could be upgrade to this commit https://github.com/ocurrent/solver-service/tree/4e161fc300bc39675630d4e1059c363dbcb9c50f just before the port on eio. Do not hesitate to DM me, I'm willing, even to review the code, I've good knowledge of that part of the code.

@shonfeder
Copy link
Contributor

Seems like #86 would obviate the need for this.

We need to make a decision on the role of the solver services, and then decide our priorities here accordingly.

@mtelvers
Copy link
Member

I note that the solver service, which @talex5 has recently improved, is now very fast. It would be great to get docs.ci.ocaml.org to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants