Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sohkd: do not use a hardcoded value for the odilia key #11

Closed
TTWNO opened this issue Aug 14, 2022 · 1 comment · Fixed by #99
Closed

sohkd: do not use a hardcoded value for the odilia key #11

TTWNO opened this issue Aug 14, 2022 · 1 comment · Fixed by #99
Milestone

Comments

@TTWNO
Copy link
Member

TTWNO commented Aug 14, 2022

At this time, the Odilia key only be capslock, due to a line in the code that explicitly ignores all capslock key presses.

// Don't emit command to virtual device if it's from a valid hotkey
// TODO: this will make sure that individual capslock keys send without any other modifiers or keys pressed will ALWAYS be consumed. This should be an option.
if !command_in_hotkeys && !(keyboard_state.state_keysyms.iter().count() == 0 && keyboard_state.state_modifiers.len() == 1 && keyboard_state.state_modifiers.iter().all(|&m| m == config::Modifier::CapsLock)) {
    uinput_device.emit(&[command]).unwrap();
}

Find a way to take in this key as a permenantly ignored key by itself. Maybe even see if it could be a keysym; this would be beneficial for those on desktop computers who want to use WP_Insert instead of capslock. Or maybe you have a specialized keyboard and you have a hyper key or whatever.

Anyway, just want to log this for future development. It would be good if Odilia can be the easiest screenreader to integrate with all environments :)

@TTWNO TTWNO added this to the 1.0 milestone Oct 3, 2022
@TTWNO
Copy link
Member Author

TTWNO commented Oct 18, 2022

waycrate/swhkd#165

@TTWNO TTWNO linked a pull request Mar 4, 2023 that will close this issue
@TTWNO TTWNO closed this as completed in #99 Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant