Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inherit locale for new instances created through linked_table #192

Open
linl33 opened this issue Mar 3, 2021 · 14 comments · May be fixed by odk-x/app-designer#191
Open

Inherit locale for new instances created through linked_table #192

linl33 opened this issue Mar 3, 2021 · 14 comments · May be fixed by odk-x/app-designer#191
Assignees
@Ndacyayisenga-droid
Labels
enhancement New feature or request good first issue Good for newcomers Survey ODK-X Survey

Comments

@linl33
Copy link
Member

linl33 commented Mar 3, 2021

When a new instance is created through linked_table the new instance uses the default locale. If the parent instance uses a non-default locale, the child instance should inherit the locale used in the parent form.

This could be implemented by passing _locale to the new instance (if one isn't provided in newInstanceKeyToValueMap) at the line linked below
https://github.com/odk-x/app-designer/blob/7abf14b16d940850cedfa66e2f9c2afd79553b3e/app/system/survey/js/prompts.js#L1035-L1038
@linl33 linl33 added enhancement New feature or request good first issue Good for newcomers Survey ODK-X Survey easy win labels Mar 3, 2021
@linl33 linl33 changed the title Inherit locale for new instanced created through linked_table Inherit locale for new instances created through linked_table Mar 3, 2021
@kdsanskar07
Copy link

Hi @linl33,
I want to work on this issue, can you share some more detail?

@linl33
Copy link
Member Author

linl33 commented Mar 11, 2021

Hi @kdsanskar07!
For general getting started information, see https://forum.odk-x.org/t/welcome-gsoc-applicants/1195. If you have a specific question let me know.

@linl33
Copy link
Member Author

linl33 commented Mar 30, 2021

@kdsanskar07 Could you give us an update on this issue? Let us know if you have any questions.

@kdsanskar07 kdsanskar07 removed their assignment Apr 6, 2021
@starboi02
Copy link

@linl33 @wbrunette can I work on this?

@wbrunette
Copy link
Member

@starboi02 I am assigning this issue to you, but you have now reached a limit. Please complete the other issues or tell us which ones you are not going to work on.

@starboi02
Copy link

starboi02 commented Apr 8, 2021 •
edited
Loading

@wbrunette I am stuck at #228 for days, I tried every possible way but was unable to recreate the issue, hence becoming very difficult for me to sort it out and fix it. Apart from it I have made a PR for #209 and a PR for #190. I am very much willing to work on this issue.

@wbrunette
Copy link
Member

@starboi02 it's assigned.

@starboi02
Copy link

@starboi02 it's assigned.

Thanks @wbrunette :)

@wbrunette
Copy link
Member

@starboi02 can you give us an update on this issue? Do you have any questions?

@starboi02
Copy link

@wbrunette I am unable to resolve what newInstanceKeyToValueMap is. Can you please give some insight on it.

@linl33
Copy link
Member Author

linl33 commented Apr 16, 2021

@starboi02 It's a typo, I meant to write newInstanceElementKeyToValueMap. This variable contains the evaluated value for newRowInitialElementKeyToValueMap. See https://docs.odk-x.org/xlsx-converter-reference/?highlight=newrowinitialelementkeytovaluemap#queries for more on newRowInitialElementKeyToValueMap

@greatestofal
Copy link

Hello @linl33, can I please work on this? What do I need to get started? Thanks

@elmps2018
Copy link

Hi @greatestofal I have assigned this to you! Please see the previous comments in this thread for details on how to get started and let us know questions!

@Ndacyayisenga-droid
Copy link

@wbrunette @elmps2018 @linl33 can you please assign this issue. I have a PR for this issue along side this too.
Am just waiting for soomeone to assign then I push PRs

@Ndacyayisenga-droid Ndacyayisenga-droid linked a pull request Feb 13, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ndacyayisenga-droid Ndacyayisenga-droid

Labels
enhancement New feature or request good first issue Good for newcomers Survey ODK-X Survey
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Inherit locale for new instances created through linked_table Ndacyayisenga-droid/app-designer
7 participants
@linl33 @wbrunette @elmps2018 @kdsanskar07 @starboi02 @Ndacyayisenga-droid @greatestofal