Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on external XDS repository and PDQ for the unit tests #8

Open
bmehner opened this issue May 3, 2012 · 3 comments
Milestone

Comments

@bmehner
Copy link
Member

bmehner commented May 3, 2012

Currently the tests in coala-ipf subsystem are dependent on external running systems providing XDS and PDQ interfaces.

Thus these tests are integration tests and not self-contained. There are two possible solutions for this:

  • Either we rewrite them to be real unit tests not interacting with external systems
  • Or we provide a mock implementation for the corresponding IHE providers that get started automatically by each test

Prerequisite for this is issue #18.

@ghost ghost assigned bmehner May 3, 2012
@ghost
Copy link

ghost commented May 6, 2012

i tend to have a mock implementation here, acting as a IHE conformant Registry/Repository. Is there a set of common interfaces ensuring no need to touch our current implementation?

@bmehner
Copy link
Member Author

bmehner commented May 11, 2012

I think we need both. In coala-communication we can replace the references to coala-ipf-pdq and coala-ipf-xds with some mocking on basis of easymock.

In coala-ipf-* we need some actual lightweight mock implementation. I hope we can do this with the help of IPF to implement some quite dumb memory mocks for this.

For example the PDQ result could always be the same one patient regardless of the search parameter. And the XDS repository and registry could store BPPC documents in memory.

@bmehner
Copy link
Member Author

bmehner commented May 25, 2012

For the time being I have deactivated the tests. This way the build is working again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant