Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsolete error message for GenericStorage? #1008

Closed
jokochems opened this issue Nov 1, 2023 · 1 comment · Fixed by #1066
Closed

Obsolete error message for GenericStorage? #1008

jokochems opened this issue Nov 1, 2023 · 1 comment · Fixed by #1066

Comments

@jokochems
Copy link
Member

When I worked on #1007 and looked into the Coveralls output, I detected an Error message for the GenericStorage class to be uncovered. It can be found here.

I think it is outdated anyways and instead, we want the Investment object to be passed to nominal_storage_capacity. Thus, in my understanding, it could be safely removed. What do you think?

@p-snft
Copy link
Member

p-snft commented Nov 8, 2023

You are right, the warning is unreachable now.

@p-snft p-snft linked a pull request May 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants