-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/rework periodic value deserialisation #154
Conversation
Also adding in decision lists and Docstring
Removing breaking capacity changes
Unfortunately test failes when a periodical changing value for "capacity" is added. Deserializing for
|
Setting Capacity to periodical changing value failed as intended by solph when building flows. Therefore added capacity periodical values to storage (since it is Investment object) Note: Improvment in _flow Code style using else instead of 'pre setting' values could be improved. Throwing error might also be useful sometime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Thanks a lot
3865a24
to
65ae4e7
Compare
Description
To implement multiperiod feature multiple values might be passed for one facade. Therefore implemented array values that need to be unpacked to either act as periodical values, yearly values or as full series.
Fixes #151
Type of change
Please tick or delete options that are not relevant.
Checklist:
Please tick or delete options that are not relevant.
pre-commit
hooks