Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deep linking to runs on schedule pages #31

Closed
Tracked by #29
Planks opened this issue Aug 20, 2021 · 7 comments
Closed
Tracked by #29

Deep linking to runs on schedule pages #31

Planks opened this issue Aug 20, 2021 · 7 comments

Comments

@Planks
Copy link

Planks commented Aug 20, 2021

The schedule page should have two deep linking functions - individual runs via run UUID and #now

In page references often suffer from being implemented with no discovery, so we should address that as follows by exposing them to the user in the following places:

  • Each run row should have a "share" link in the expanded view which simply links back to the row in question. It should be marked as rel="nofollow" as it is circular.
  • #now should be able to be discovered from a similar link available close to the "now and next" box at the top of the page. Again, as it's circular, it should also be rel="nofollow"
@Planks Planks mentioned this issue Aug 20, 2021
21 tasks
@BobChao87
Copy link
Contributor

We could also do #next, I can see that being useful for people. We also have the option of using the run's position in the marathon instead of the UUID, though I'm unsure if that's immutable or not.

@Planks
Copy link
Author

Planks commented Aug 20, 2021

We could also do #next, I can see that being useful for people. We also have the option of using the run's position in the marathon instead of the UUID, though I'm unsure if that's immutable or not.

Good point - I agree we should also have #next. In v1 we already have "now" and "next" highlight boxes at the top of each live schedule, but you can't click on them. So these wouldn't need extra share buttons, you'd just make the boxes hotspots.

@Planks
Copy link
Author

Planks commented Aug 20, 2021

We also have the option of using the run's position in the marathon instead of the UUID, though I'm unsure if that's immutable or not.

I don't think linking by any sort of relative ordering is useful because organisers move around runs so much. The use case for deep linking a row is mostly so people can link directly to a specific run in the schedule and we'd want that link to remain valid through all schedule edits.

@BobChao87
Copy link
Contributor

We also have the option of using the run's position in the marathon instead of the UUID, though I'm unsure if that's immutable or not.

I don't think linking by any sort of relative ordering is useful because organisers move around runs so much. The use case for deep linking a row is mostly so people can link directly to a specific run in the schedule and we'd want that link to remain valid through all schedule edits.

I was afraid that was the case. Oh well, it was worth a shot as then the link would have been slightly more meaningful. Consistency is better.

@Planks
Copy link
Author

Planks commented Aug 20, 2021

If @duncte123 would be able to tweak the database, at submission time a "friendly uuid" could be generated and added to the submission row like

BobChao87-MickeyMouseGame-kasdjf where kasdjf is just some garbage to deduplicate

Seems a lot of work for a relatively minor feature but it would make the URLs much, much nicer particularly when linked on an instant messenger like Discord.

We don't want the URL to expire if any of the run properties are changed so this is something that would need to be locked in permanently when the submission is first created.

BobChao87 added a commit that referenced this issue Aug 20, 2021
@BobChao87
Copy link
Contributor

Yeah, I agree. We'll just stick with our existing immutable properties and maybe in the future we can revisit. I made them a little clearer by making the anchor be #run-UUID.

@BobChao87
Copy link
Contributor

Will be considered resolved after this issue is fixed. #32 (comment)

BobChao87 added a commit that referenced this issue Sep 29, 2021
Also divorced some internal logic for the $scroll plugin.

Related to Issues #31, #32
BobChao87 added a commit that referenced this issue Sep 29, 2021
@Planks Planks closed this as completed Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants