Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scroll Positioning #32

Open
BobChao87 opened this issue Aug 27, 2021 · 1 comment
Open

Scroll Positioning #32

BobChao87 opened this issue Aug 27, 2021 · 1 comment
Assignees
@BobChao87
Labels
enhancement New feature or request M1C2 Milestone 1 - Checkpoint 2
Milestone
Oengus Webapp v2 ...

Comments

@BobChao87
Copy link
Contributor

When navigating around the site, the scroll position of the page stays fixed when navigating by clicking on link. The back/forward buttons correctly preserve scroll position. We need to change this to continue to preserve scroll position on back/forward navigation, but to scroll to the top on navigation to a "new" page (i.e. when clicking on a link).
@BobChao87 BobChao87 added enhancement New feature or request M1C2 Milestone 1 - Checkpoint 2 labels Aug 27, 2021
@BobChao87 BobChao87 self-assigned this Aug 27, 2021
BobChao87 added a commit that referenced this issue Aug 27, 2021
@BobChao87
Scroll to top on nav, but not back/forward
0c0beef 
Related to Issue #32
@BobChao87
Copy link
Contributor Author

Clicking on the same link again when that link is a hash should scroll back to that item, as is standard browser behaviour, but it doesn't. It should.

@BobChao87 BobChao87 mentioned this issue Sep 26, 2021
Closed
BobChao87 added a commit that referenced this issue Sep 29, 2021
@BobChao87
Replace NuxtLink with ElementLink
a6e9e4c 
This allows us to have active classes on hash mapped routes for the page
and the anchor links. This will also allow us to place more complex
logic onto our linkings where relevant.

Related to Issue #32
BobChao87 added a commit that referenced this issue Sep 29, 2021
@BobChao87
Repeated clicks on the same hash link work
cc2a2b3 
Also divorced some internal logic for the $scroll plugin.

Related to Issues #31, #32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BobChao87 BobChao87

Labels
enhancement New feature or request M1C2 Milestone 1 - Checkpoint 2
Projects
None yet
Milestone
Oengus Webapp v2 - Milestone 1 - Setu...
Development

No branches or pull requests
1 participant
@BobChao87