Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table Rework #43

Open
BobChao87 opened this issue Sep 28, 2021 · 0 comments
Open

Table Rework #43

BobChao87 opened this issue Sep 28, 2021 · 0 comments
Assignees

Comments

@BobChao87
Copy link
Contributor

Replace the abused notification class from Bulma currently being used to produce tables on the site. The objectives of this replacement are several:

  • Reduce repetition necessary to make the notification boxes display more table-like.
  • Make lines less jarring when alternating odds/evens. Currently the font color changes and it's jarring.
  • Provide specific classes for the various row types.
    • Even/Odd: alternating colors (lighter and darker) that make it easier to tell lines apart
    • Focus: When a row requires emphasis, such as the current run in a schedule.
    • Info/Header: Rows that contain information that isn't part of the table itself such as a header or date separators. Possibly distinct.
  • Supports expansion boxes, a la the schedule run info boxes.

Ideally, we'd also make a nice component to help make tables more easily, but that might difficult for a variety of reasons, not least of which if the lack of subgrid CSS support. Instead, a collection of SCSS mixins that will help regulate display wouldn't be a bad idea.

@BobChao87 BobChao87 self-assigned this Sep 28, 2021
BobChao87 added a commit that referenced this issue Oct 19, 2021
Supports fancy styling colors and a decent level of customization
This is just barely more than a minimum viable product, more will come

Related to Issue #43
BobChao87 added a commit that referenced this issue Oct 19, 2021
Probably missed some stuff that could nicely migrate out,
but this is nice for now.

Related to Issue #43
BobChao87 added a commit that referenced this issue Oct 22, 2021
Because Bulma/Bulmaswatch weren't made for @use, they leak and repeat
In theory, they only repeat once per "compiled CSS,"
but global and components are separate, so it infects component scope.

Related to Issue #43
BobChao87 added a commit that referenced this issue Oct 22, 2021
BobChao87 added a commit that referenced this issue Oct 23, 2021
For some reason, it's not meshing well with timezone-based rehydration

Related to Issue #43
BobChao87 added a commit that referenced this issue Nov 4, 2021
This will allow consistent, reusable behavior throughout the project

Related to Issue #43
BobChao87 added a commit that referenced this issue Nov 4, 2021
Allows for safe embedding of Table Cells in an encapsulated way
Allows for certain CSS properties to be passed along to the Cells
Allows for how row interactions

Related to Issue #43
BobChao87 added a commit that referenced this issue Nov 4, 2021
Proof of concept of idea

Related to Issues #39, #43
BobChao87 added a commit that referenced this issue Nov 4, 2021
Additionally, switched to using the global table shrink function
This allows a lot of row logic to go on the row instead of every cell :)

Related to Issue #43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant