-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase API version to 1.1 #126
Comments
Do we need semver on the API? Breaking changes would need a new version imho, but something new that won't break existing clients can just as well be thrown in there. Just my two cents. |
Well the minor version would specify a minimum feature set. So 1.1 has all features that 1.0 has plus an additional feature. A client can say it needs 1.1, because it needs this feature but older clients can still use 1.1 since it includes all older features. |
Ok, why not. Go for it. |
Unless this breaks older clients relying on the version being specifically set to 1.0? Are we running both at the same time? |
i have no idea 😄 |
Looks like I am, damn :D Please leave it at 1.0 for now^^ Will fix soon. |
please also see #140 |
Obsolete because of #140 and because nobody implements this yet. |
I recommend to increase the API version to 1.1 so clients can see if an attribution field is supplied or not (even though it is optional).
Due to the architecture, the attribution field is not omitted if no attribution is given but null, therefore the API version would flag the existence of this field.
This can surely be catched by clients but I think increasing the minor version is a more clean way.
See #125.
The text was updated successfully, but these errors were encountered: