Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase API version to 1.1 #126

Closed
jklmnn opened this issue Jun 29, 2016 · 8 comments
Closed

Increase API version to 1.1 #126

jklmnn opened this issue Jun 29, 2016 · 8 comments

Comments

@jklmnn
Copy link
Member

jklmnn commented Jun 29, 2016

I recommend to increase the API version to 1.1 so clients can see if an attribution field is supplied or not (even though it is optional).
Due to the architecture, the attribution field is not omitted if no attribution is given but null, therefore the API version would flag the existence of this field.
This can surely be catched by clients but I think increasing the minor version is a more clean way.

See #125.

@kiliankoe
Copy link
Member

Do we need semver on the API? Breaking changes would need a new version imho, but something new that won't break existing clients can just as well be thrown in there. Just my two cents.

@jklmnn
Copy link
Member Author

jklmnn commented Jun 29, 2016

Well the minor version would specify a minimum feature set. So 1.1 has all features that 1.0 has plus an additional feature. A client can say it needs 1.1, because it needs this feature but older clients can still use 1.1 since it includes all older features.

@kiliankoe
Copy link
Member

Ok, why not. Go for it.

@kiliankoe
Copy link
Member

Unless this breaks older clients relying on the version being specifically set to 1.0? Are we running both at the same time?

@jklmnn
Copy link
Member Author

jklmnn commented Jun 29, 2016

i have no idea 😄

@kiliankoe
Copy link
Member

Looks like I am, damn :D Please leave it at 1.0 for now^^ Will fix soon.

@kiliankoe
Copy link
Member

please also see #140

@jklmnn
Copy link
Member Author

jklmnn commented Apr 24, 2019

Obsolete because of #140 and because nobody implements this yet.

@jklmnn jklmnn closed this as completed Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants