From 54cdc266c80fadf4543a8bb7de4bb6a79e1b9146 Mon Sep 17 00:00:00 2001
From: Matthias Fischmann <mf@zerobuzz.net>
Date: Mon, 14 Oct 2024 14:55:19 +0200
Subject: [PATCH] [WPB-11472] Revert "Work around legacy integration test
 resource leak. (#4244)" (#4287)

* Revert "Work around legacy integration test resource leak. (#4244)"

This reverts commit a72c70a9a9b9d71af1b864384e80b6d3eb0827a9.

(it turns out this only helps with resource consumption because
after running the first bach of tests, defaultMainWithIngredients
exits...  m|

* hi ci
---
 services/brig/test/integration/Run.hs | 28 ++++++++-------------------
 1 file changed, 8 insertions(+), 20 deletions(-)

diff --git a/services/brig/test/integration/Run.hs b/services/brig/test/integration/Run.hs
index 9cfadcf53b1..36adc72a8ec 100644
--- a/services/brig/test/integration/Run.hs
+++ b/services/brig/test/integration/Run.hs
@@ -54,7 +54,6 @@ import Options.Applicative hiding (action)
 import SMTP qualified
 import System.Environment (withArgs)
 import System.Logger qualified as Logger
-import System.Mem (performGC)
 import Test.Tasty
 import Test.Tasty.Ingredients
 import Test.Tasty.Runners
@@ -151,14 +150,16 @@ runTests iConf brigOpts otherArgs = do
   let smtp = SMTP.tests mg lg
       oauthAPI = API.OAuth.tests mg db b n brigOpts
 
-  -- run the tests in two parts, with a gc in between. i did this on a hunch, and for some
-  -- reason this reduces the hunger for open file handles at run time significantly, and makes
-  -- the suite pass with my ulimit settings.  (fisx)
-
   withArgs otherArgs . defaultMainWithIngredients (listingTests : (composeReporters antXMLRunner consoleTestReporter) : defaultIngredients)
     $ testGroup
-      "Brig API Integration, part 1"
-    $ [ systemSettingsApi,
+      "Brig API Integration"
+    $ [ userApi,
+        providerApi,
+        searchApis,
+        teamApis,
+        turnApi,
+        metricsApi,
+        systemSettingsApi,
         settingsApi,
         createIndex,
         userPendingActivation,
@@ -169,19 +170,6 @@ runTests iConf brigOpts otherArgs = do
         oauthAPI,
         federationEnd2End
       ]
-
-  performGC
-
-  withArgs otherArgs . defaultMainWithIngredients (listingTests : (composeReporters antXMLRunner consoleTestReporter) : defaultIngredients)
-    $ testGroup
-      "Brig API Integration, part 2"
-    $ [ userApi,
-        providerApi,
-        searchApis,
-        teamApis,
-        turnApi,
-        metricsApi
-      ]
   where
     mkRequest (Endpoint h p) = Bilge.host (encodeUtf8 h) . Bilge.port p