Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required Fields Error and Unnecessary Network Requests #9733

Open
rajku-dev opened this issue Jan 4, 2025 · 1 comment · May be fixed by #9749
Open

Required Fields Error and Unnecessary Network Requests #9733

rajku-dev opened this issue Jan 4, 2025 · 1 comment · May be fixed by #9749
Assignees

Comments

@rajku-dev
Copy link
Contributor

rajku-dev commented Jan 4, 2025

  • Submit button should be disabled using isDirty property from react-hook-form in Update Encounter form to prevent unnecessary network requests

Image

Image

  • Date of Birth can't be in future - update zod schema
  • Phone number field should not take more than 10 numbers after +91
  • Have a red asterisk in front of the label of all required fields just like State field.

To Reproduce
Click here

Expected behavior
Submit button should be disabled if no changes are made to form

@rajku-dev
Copy link
Contributor Author

rajku-dev commented Jan 4, 2025

@rithviknishad Can i work on this task.

@rajku-dev rajku-dev changed the title Required Fields Error Required Fields Error and Unnecessary Network Requests Jan 4, 2025
@rajku-dev rajku-dev linked a pull request Jan 4, 2025 that will close this issue
6 tasks
@Jacobjeevan Jacobjeevan marked this as a duplicate of #9791 Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant