-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Identify First-Time PR Contributors for Last Week #576
Add: Identify First-Time PR Contributors for Last Week #576
Conversation
👷 Deploy request for leaderboard-develop pending review.Visit the deploys page to approve it
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of directly keeping the logic here, let's add it to the contributor object itself. so that this value isNewContributor
could be reused everywhere else when needed.
Also not a fan of the design. Let's not have |
Shall I add this logic in getContributorBySlug function? |
yup! that's the right place to be |
….com/JavidSumra/care_leaderboard into issues/153/highlight-new-contributor
….com/JavidSumra/care_leaderboard into issues/153/highlight-new-contributor
@rithviknishad can you please review this PR? |
@rithviknishad can you please review this PR and clarify doubts? |
….com/JavidSumra/care_leaderboard into issues/153/highlight-new-contributor
Fixes #153
Description
This PR implements logic to identify first-time PR contributors whose first
pr_merged
activity occurred within the specified time frame (last week). It ensures accuracy by filtering contributors based on their activities and checks if their first contribution happened during last week.Screenshots / Outputs