Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scaling points for PRs based on size of the PR #409

Closed
wants to merge 6 commits into from
Closed

Scaling points for PRs based on size of the PR #409

wants to merge 6 commits into from

Conversation

Samuel-Aktar-Laskar
Copy link
Contributor

Closes #219

Update in Scraper (github.py)
I checked the count of linked issues to a pr from pr body and added field "no_of_linked_issue" to the event.

In the api.ts file, I adjusted the code account for no of linked issues. So now total point for a PR would be (1 for opening pr + no of linked issues).

@vercel Vercel
Copy link

vercel bot commented Mar 29, 2024

@Samuel-Aktar-Laskar is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

@bodhish bodhish requested a review from rithviknishad March 30, 2024 08:06
rithviknishad
rithviknishad requested changes Mar 30, 2024
View reviewed changes
scraper/src/github.py Outdated Show resolved Hide resolved
scraper/src/github.py Outdated Show resolved Hide resolved
scraper/src/github.py Show resolved Hide resolved
lib/api.ts Outdated Show resolved Hide resolved
lib/api.ts Outdated Show resolved Hide resolved
lib/api.ts Outdated Show resolved Hide resolved
@Samuel-Aktar-Laskar
Copy link
Contributor Author

@rithviknishad
I have created separate file for parser where I collect the linked issues from pr body description, commits messages and UI linked issue. For UI linked issue, I am using graphql (https://stackoverflow.com/a/61940472). Let me know if there is any better way to do. I tested the same by making demo issue and prs in my own account, and it seems to work fine.

Rest are the changes in sorting logic.
Let me know the changes or improvements required.

@rithviknishad
Copy link
Member

@Samuel-Aktar-Laskar

We have moved away from python based github scraper and we are now using octokit in typescript to achieve the same. We can use octokit's graphql fn. to perform graphql calls to scrape data too!

Feel free to re-open a fresh PR 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad Awaiting requested review from rithviknishad

Assignees
No one assigned
Labels
changes required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scaling points for PRs based on size of the PR / complexity of the issue
2 participants
@Samuel-Aktar-Laskar @rithviknishad