Replace/imrpove regex parsing for extracting co-authors of pr_collaborated events

[rithviknishad]

At times the pr_collaborated event yields incorrect co-author results

leaderboard/scraper/src/github-scraper/parseEvents.ts

Lines 53 to 55 in ad4cb04

	const coAuthors = commit.commit.message.match(
	/Co-authored-by: (.+) <(.+)>/,
	);

[rithviknishad]

• https://github.com/coronasafe/leaderboard-data/blob/main/data/github/7.json
• https://github.com/coronasafe/leaderboard-data/blob/main/data/github/o.json

[vikram-8290]

hii @rithviknishad i want to work on this issue i have understand that what is wrong with this but not to get that where should i make this chances , is there any documentation so the reference, is there any way you can help with this,
Thanks.

[rithviknishad]

https://docs.ohc.network/docs/leaderboard/gsoc-2024/refactor-scraper#3-parseeventsts

leaderboard/scraper/src/github-scraper/parseEvents.ts

Lines 53 to 55 in ad4cb04

	const coAuthors = commit.commit.message.match(
	/Co-authored-by: (.+) <(.+)>/,
	);

[vikram-8290]

One thing I've identified is that the current implementation only captures a single match for the regex pattern /Co-authored-by: (.+) <(.+)>/, which can be problematic if there are multiple Co-authored-by entries in the commit message. Additionally, any slight variations in the format (like additional spaces or different capitalizations) could result in missed matches.

Proposed Fix:

Adjust the regular expression or use a more robust method to handle multiple Co-authored-by entries.
Implement a loop to capture all matches in the commit message rather than just the first occurrence.
Would you like me to implement this fix, or do you foresee any other potential issues to consider before moving forward?

[rithviknishad]

The core issue is, it's parsing authors incorrectly as mentioned in #492 (comment)

Finding all co-authors, nice find, it can simply be done by using matchAll instead of match right? Why create a loop and all?

[vikram-8290]

Yes, you’re correct that using matchAll is a great way to capture all co-authors in the commit message. However, we still need a loop to process each match individually.

Here’s why the loop is necessary:

1. Iterating Through Matches: matchAll returns an iterator of all matches, and we need to loop through these matches to extract and process each co-author’s information.

2. Processing Logic: For each co-author, we need to check for conditions such as whether they are blacklisted or whether their names/emails are in our caches. The loop allows us to implement this logic for every individual match.

So, while matchAll helps us find all the matches, the loop is essential for handling the processing of each co-author found in the commit message.

If you're open to it, I can go ahead and implement this fix!

[vikram-8290]

I have created a pull request #519 . Please Check and let me Know if i have made some mistake.
Thanks

[Srayash]

hey @rithviknishad! waiting for review on #541.