Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve install script #6

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Improve install script #6

merged 2 commits into from
Dec 11, 2024

Conversation

ohmer
Copy link
Owner

@ohmer ohmer commented Dec 11, 2024

Apply shellcheck recommendations.
Remove binary when download or checksum fails.

@ohmer ohmer self-assigned this Dec 11, 2024
@ohmer
Copy link
Owner Author

ohmer commented Dec 11, 2024

@yhakbar would you mind looking at this?

@ohmer ohmer changed the title Apply with shellcheck recommandation. Remove binary when download or checksum fails. Improve install script Dec 11, 2024
Copy link

@yhakbar yhakbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ohmer ohmer merged commit 29f2935 into main Dec 11, 2024
2 checks passed
@ohmer ohmer deleted the shellcheck-and-rm branch December 11, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants