Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove downsampling and filtering? #33

Open
iainrb opened this issue Mar 2, 2020 · 3 comments
Open

Remove downsampling and filtering? #33

iainrb opened this issue Mar 2, 2020 · 3 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@iainrb
Copy link
Collaborator

iainrb commented Mar 2, 2020

In new versions of the bam-qc workflow, filtering and downsampling will be done upstream by other workflow tasks. So, the filtering/downsampling capabilities of bam-qc-metrics itself will no longer be used. We could:

  • Remove the downsampling functionality from bam-qc-metrics to simplify code
  • Remove output fields referring to filtering/downsampling results in bam-qc-metrics, to simplify output and reduce potential confusion. (Eg. "total reads", "unmapped reads".)

Low-priority, but could be useful. Should we do it?

@iainrb iainrb added question Further information is requested enhancement New feature or request labels Mar 2, 2020
@slazicoicr
Copy link
Contributor

I am happy with either/both options. In my thinking, bam-qc should generate metrics for the input data and not modify it in any way (by filtering and down sampling). That way we have clear separation between data wrangling and metric reporting.

@iainrb
Copy link
Collaborator Author

iainrb commented Mar 3, 2020

Yes, I agree.

I'll make a ticket and put this on the TODO list. Probably won't be implemented on this iteration but we can do it when time allows.

@iainrb
Copy link
Collaborator Author

iainrb commented Mar 3, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants