Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors are not from colorscheme #18

Open
vektah opened this issue Sep 30, 2013 · 13 comments
Open

Colors are not from colorscheme #18

vektah opened this issue Sep 30, 2013 · 13 comments

Comments

@vektah
Copy link

vektah commented Sep 30, 2013

Great plugin! One little problem in the 0.3.0 release.

The plugin used to use the colors from colors & fonts -> general -> uncovered line / partial line coverage / full line coverage. Now it defaults to bright red and green (probably FF0000 and 00FF00).

This is unreadable on dark backgrounds:
crazy colors

@oker1
Copy link
Owner

oker1 commented Oct 1, 2013

I think this is a sideeffect, you were using the built in coverage support, because the clover.xml was not configured in the plugin settings. This new release picks up the clover xml automatically, and it started working for you.

This feature would make a nice addition, so I'll look into using the color scheme instead of a separate setting in the plugin, if it's possible, thanks for the report!

@WebnetMobile
Copy link

@oker1 can you please look into this in 2015? Would be really much more consistent if IDE's colors are used instead of having this somehow redundant color settings and it would automatically (partially) address the #12

@aimfeld
Copy link

aimfeld commented Jun 12, 2015

@oker1 Great plugin! +1 for using the IDE's color scheme, I have a hard time reading the text with the dark theme enabled (Darcula)

@markushausammann
Copy link

+1 👍

@ravanscafi
Copy link

👍

@rackberg
Copy link

Whats the status here? I'm facing the same problem using the 0.5.0 release with phpstorm 2016.1

@nubeiro
Copy link

nubeiro commented May 10, 2016

+1

@emaas
Copy link

emaas commented Jun 1, 2016

Yes, i'm facing the same issue and would love to see this solved.
I'm using 2016.1.2 on Windows 10
For the rest, it's an amazingly usefull plugin.

@tarlepp
Copy link

tarlepp commented Jun 18, 2016

+1

@therpr
Copy link

therpr commented Aug 10, 2016

It works fine if you set the color in (colors)->Line coverage->Full, you then have to rerun your tests with coverage.
zrzut ekranu 2016-08-10 o 14 56 41

@REBELinBLUE
Copy link

REBELinBLUE commented Aug 24, 2016

I have the colours set for Full (484848), Partial (80805A) and Uncovered (715353) but they still show as bright green and red

Ah, I had them set in foreground not background

@fracz
Copy link

fracz commented Oct 20, 2016

+1 for this.

Although this plugin works, it's unusable because of the hardcoded colors.

@kgkg
Copy link

kgkg commented Dec 16, 2016

Any chance of addressing this issue, anyone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests