Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI thread blocking in OktaSdkBridgeModule causing app unresponsiveness #429

Open
anujsachan1990 opened this issue Sep 6, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@anujsachan1990
Copy link

Describe the bug?

The OktaSdkBridgeModule is currently performing several operations on the main UI thread, which can lead to app unresponsiveness, especially on devices with limited resources or slow network connections. This affects methods such as createConfig, signIn, and authenticate.

This may be unnoticeable in a few devices but I can see it clearly in Pixel 6,7,8 which are not too old devices. The UI Thread should not be blocked.

The Fix is here:
#428

What is expected to happen?

The app should remain responsive during Okta SDK operations, with no noticeable UI freezing or lag.

What is the actual behavior?

The app becomes unresponsive or experiences significant lag during Okta SDK operations, particularly on slower devices or networks.

Reproduction Steps?

  1. Initialize the Okta SDK using createConfig
  2. Attempt to sign in using signIn or authenticate method
  3. Observe UI responsiveness, especially on slower devices or networks

Additional Information?

https://github.com/user-attachments/assets/36b489be-2ff1-4439-8840-10dff45

when this method is called it blocked the UI thread
Screenshot 2024-09-06 at 4 09 51 pm
70268

SDK Version

"@okta/okta-react-native": "^2.8.0",

Build Information

No response

@anujsachan1990 anujsachan1990 added the bug Something isn't working label Sep 6, 2024
@anujsachan1990
Copy link
Author

fix is here if anyone wat to use patch-package
#428
@okta+okta-react-native+2.12.0.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant