Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slashes in app, test names runs but breaks things later #129

Open
hagertnl opened this issue Aug 10, 2023 · 1 comment
Open

Slashes in app, test names runs but breaks things later #129

hagertnl opened this issue Aug 10, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@hagertnl
Copy link
Contributor

If you run a test like:

Test = unit_tests grouping1/test_1

with the intention of grouping some tests within subdirectories in the repository, the test technically runs successfully, but "grouping1" becomes the application name in the status files (and in InfluxDB), instead of unit_tests.
Directories are all set up correctly, but I assume that there's some sort of relative path checking to derive the application and test name, where it should just be set by what is provided in the input file.

Current Result:
app=grouping1 test=test_1

Expected:
app=unit_tests test=grouping1/test_1

@ddietz89
Copy link
Contributor

We should validate inputs don't have slashes like this, but later look at adding test grouping support.

@hagertnl hagertnl added the bug Something isn't working label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants