Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several classes in harness code do not have access to a logger #130

Open
hagertnl opened this issue Aug 29, 2023 · 3 comments
Open

Several classes in harness code do not have access to a logger #130

hagertnl opened this issue Aug 29, 2023 · 3 comments
Labels
bug Something isn't working invalid This doesn't seem right

Comments

@hagertnl
Copy link
Contributor

Files within the harness/machine_types directory do not have access to a logger, and do all messaging through print(). Some of these messages should certainly be logged at a lower threshold than what print provides. Recommend passing the apptest logger into each machine type.

@hagertnl
Copy link
Contributor Author

For example, a scheduler (ie, lsf.py) will always print the command & return code of the command used to submit the job. This is useful most of the time, but it's also not logged to a log file, so once you leave the current screen, you will never see it again.

@hagertnl hagertnl changed the title Classes in harness/machine_types do not have access to a logger Several classes in harness code do not have access to a logger Aug 29, 2023
@hagertnl
Copy link
Contributor Author

List of classes/files without access to a logger that would benefit from access to a logger:

  • machine_types/*
  • libraries/rgt_utilities.py (needed especially for set_harness_environment. This causes a lot of extra output)
  • libraries/config_file.py
  • libraries/input_files.py
  • do_application_tasks in libraries/apptest.py

@hagertnl
Copy link
Contributor Author

These were identified through work in PR #114 , but are not fixed in this PR.

@hagertnl hagertnl added invalid This doesn't seem right bug Something isn't working labels Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant