refactor: fix logic for IBinaryInteger<T>.Factorial

The algorithm now starts at IBinaryInteger<T>.MultiplicativeIdentity rather than IBinaryInteger<T>.One
oliverbooth · Nov 14, 2024 · c7e78f5 · c7e78f5
1 parent 024f6db
commit c7e78f5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+- X1OD: `IBinaryInteger<T>.Factorial` now starts at `IBinaryInteger<T>.MultiplicativeIdentity` not
+`IBinaryInteger<T>.One`.
 - X10D: Removed `byte.Product`, `short.Product`, `ushort.Product`, `int.Product`, `uint.Product`, `long.Product`,
   and `ulong.Product`, in favour of `INumber<T>.Product`.
 - X10D: Removed `byte.RangeTo`, `short.RangeTo`, `ushort.RangeTo`, `int.RangeTo`, `uint.RangeTo`, `long.RangeTo`,

diff --git a/X10D/src/Math/BinaryIntegerExtensions.cs b/X10D/src/Math/BinaryIntegerExtensions.cs
@@ -69,13 +69,13 @@ public static long Factorial<TInteger>(this TInteger value)
             return 1;
         }
 
-        var result = 1L;
+        TInteger result = TInteger.MultiplicativeIdentity;
         for (TInteger i = TInteger.One; i <= value; i++)
         {
-            result *= long.CreateChecked(i);
+            result *= i;
         }
 
-        return result;
+        return long.CreateChecked(result);
     }
 
     /// <summary>