-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attach build to GitHub releases #3
Comments
New builds |
I just saw your response to the fdroid build request. Thanks for the update. Seeing that that won't happen at least in the short term, is adding an apk file to the releases section for each new release a possibility? |
Hello @Morse6690, we know several users would be interested in an official "non store" APK but we do not want to incentivize them to install APKs signed by a random key. Also, it would be easy for anyone impersonating the github website to distribute a malicious APK. At least, F-Droid and Google Play can check the APK is properly signed. |
I can understand your concerns with this. Having said that there is a use case for this, hence apps like signal make sure they provide an apk that can be downloaded from outside the play store. |
Build ready v1.0_216-kumy1 |
Is it possible to do something similar to signal? |
Just a quick note here: we are now providing an APK for download directly from our website. This APK is a universal APK signed with the same keys as the version available on Google Play. This means push notifications can work for users with Google Services installed. We do not provide an APK for the "no google" flavor of the app. |
That's a great step forward, thanks. What are the reason behind the "We do not provide an APK for the "no google" flavor of the app."? |
Making sure the "use foreground service" option is turned on should mean that notifications will be received whether the device has Google play services installed or not? |
Hi @Morse6690 , the "use foreground service" is not exactly for this. We have a "maintain a permanent websocket connection" option that can replace Google push notifications. The "use foreground service" is just there to prevent the app from being killed in the background by the system, but it's not that useful. The websocket connection will also use a foreground service to keep the app alive. Keep in mind that the permanent websocket may drain the battery (a few percents in one day), so if you have too many apps doing the same as us, this might become an issue :) |
That's right... Forgot that other setting. I have used those two settings on my Graphenos device for 18 months. The battery drain was pretty minimal, and never had a problem receiving messages. |
For those like me using the "no google" version, I'll continue to build the releases on my side. |
I had to raise Graddle memory to have it build. v3.2 is out 🙂 |
As said in #2 (comment), it would be awesome to have already built packages signed by your own key attached to the GitHub releases. (it would also be nice to have the download apk link on your website)
This would help:
Thanks a lot!
Edit: you can find my own automated builds at https://github.com/kumy/olvid-android/releases
The text was updated successfully, but these errors were encountered: