Skip to content

Commit

Permalink
Merge pull request #254 from melissalinkert/rfc2-review1b
Browse files Browse the repository at this point in the history
Add review 1b for RFC-2
  • Loading branch information
joshmoore authored Aug 26, 2024
2 parents fc65eb3 + 926adb7 commit 6caf3a8
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 1 deletion.
3 changes: 2 additions & 1 deletion rfc/2/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Adopt the version 3 of Zarr for OME-Zarr.

## Status

This RFC is currently in RFC state (R5).
This RFC is currently in RFC state (R6).

| Role | Name | GitHub Handle | Institution | Date | Status |
| -------- | ------------------- | --------------------------------------------------- | -------------------------------------------------- | ---------- | ----------------------------------------------------------------------- |
Expand All @@ -24,6 +24,7 @@ This RFC is currently in RFC state (R5).
| Reviewer | Melissa Linkert, Sebastién Besson, Chris Allan, Jason Swedlow | glencoesoftware | Glencoe Software | 2024-05-23 | [Review](./review_1.md) |
| Reviewer | Yaroslav O. Halchenko | yarikoptic | Dartmouth College, DANDI Project | 2024-06-10 | [Review](./review_2.md) |
| Reviewer | Jeremy Maitin-Shepard | jbms | Google | 2024-04-30 | [Review](./review_3.md) |
| Reviewer | Melissa Linkert, Sebastién Besson, Chris Allan, Jason Swedlow | glencoesoftware | Glencoe Software | 2024-08-05 | [Accept](./review_1b.md) |

## Overview

Expand Down
17 changes: 17 additions & 0 deletions rfc/2/review_1b.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# Updated Review of RFC-2: Zarr v3

## Review authors
This review was written by the following Glencoe Software team members:

- Sébastien Besson
- Melissa Linkert

## Summary

The changes to RFC-2 in https://github.com/ome/ngff/pull/250 are sufficient to update our recommendation from "Major changes" to "Accept".

Our original [Concern #1](https://ngff.openmicroscopy.org/rfc/2/review_1.html#concern-1-limited-zarr-v3-implementations) is addressed by the addition of references to zarr-python and zarr-java, as well as [clarifications to the zarr-java API](https://github.com/zarr-developers/zarr-java/issues/5) prompted by work on [v2/v3 conversion tools](https://github.com/glencoesoftware/zarr2zarr). Remaining concerns in [our original review](https://ngff.openmicroscopy.org/rfc/2/review_1.html) are addressed by stronger language around how applications should handle multiple versions and the usage of ‘ome’ as the top-level key for the OME-NGFF metadata in zarr.json.

## Recommendation

Our recommendation is "Accept". Additionally, as the maintainers of the [bioformats2raw](https://github.com/glencoesoftware/bioformats2raw) and [raw2ometiff](https://github.com/glencoesoftware/raw2ometiff), we plan to implement Zarr v3 support in these libraries by the end of 2024.

0 comments on commit 6caf3a8

Please sign in to comment.