From 87db42ca9ae8456766fbbe690dfb350e92f6d0fd Mon Sep 17 00:00:00 2001 From: Melissa Linkert Date: Mon, 5 Aug 2024 08:49:05 -0500 Subject: [PATCH 1/4] Add review 1b for RFC-2 --- rfc/2/review_1b.md | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 rfc/2/review_1b.md diff --git a/rfc/2/review_1b.md b/rfc/2/review_1b.md new file mode 100644 index 00000000..4166c747 --- /dev/null +++ b/rfc/2/review_1b.md @@ -0,0 +1,17 @@ +# Updated Review of RFC-2: Zarr v3 + +## Review authors +This review was written by the following Glencoe Software team members: + +- Sebastién Besson +- Melissa Linkert + +## Summary + +The changes to RFC-2 in https://github.com/ome/ngff/pull/250 are sufficient to update our recommendation from "Major changes" to "Accept". + +Our original [Concern #1](https://ngff.openmicroscopy.org/rfc/2/review_1.html#concern-1-limited-zarr-v3-implementations) is addressed by the addition of references to zarr-python and zarr-java, as well as [clarifications to the zarr-java API](https://github.com/zarr-developers/zarr-java/issues/5) prompted by work on [v2/v3 conversion tools](https://github.com/glencoesoftware/zarr2zarr). Remaining concerns in [our original review](https://ngff.openmicroscopy.org/rfc/2/review_1.html) are addressed by stronger language around how applications should handle multiple versions and the usage of ‘ome’ as the top-level key for the OME-NGFF metadata in zarr.json. + +## Recommendation + +Our recommendation is "Accept". Additionally, as the maintainers of the [bioformats2raw](https://github.com/glencoesoftware/bioformats2raw) and [raw2ometiff](https://github.com/glencoesoftware/raw2ometiff), we plan to implement Zarr v3 support in these libraries by the end of 2024. From 1797f53c1a326362c62df713aa316581413cbf32 Mon Sep 17 00:00:00 2001 From: Melissa Linkert Date: Mon, 12 Aug 2024 08:36:12 -0500 Subject: [PATCH 2/4] Update rfc/2/review_1b.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Sébastien Besson --- rfc/2/review_1b.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rfc/2/review_1b.md b/rfc/2/review_1b.md index 4166c747..c5b7c445 100644 --- a/rfc/2/review_1b.md +++ b/rfc/2/review_1b.md @@ -3,7 +3,7 @@ ## Review authors This review was written by the following Glencoe Software team members: -- Sebastién Besson +- Sébastien Besson - Melissa Linkert ## Summary From c4eacddcb64f9d91a482d2fa1115e19a60d89a28 Mon Sep 17 00:00:00 2001 From: Josh Moore Date: Mon, 26 Aug 2024 16:19:34 +0200 Subject: [PATCH 3/4] Add review_1b to the index --- rfc/2/index.md | 1 + 1 file changed, 1 insertion(+) diff --git a/rfc/2/index.md b/rfc/2/index.md index e2c6051b..04c5d0f7 100644 --- a/rfc/2/index.md +++ b/rfc/2/index.md @@ -24,6 +24,7 @@ This RFC is currently in RFC state (R5). | Reviewer | Melissa Linkert, Sebastién Besson, Chris Allan, Jason Swedlow | glencoesoftware | Glencoe Software | 2024-05-23 | [Review](./review_1.md) | | Reviewer | Yaroslav O. Halchenko | yarikoptic | Dartmouth College, DANDI Project | 2024-06-10 | [Review](./review_2.md) | | Reviewer | Jeremy Maitin-Shepard | jbms | Google | 2024-04-30 | [Review](./review_3.md) | +| Reviewer | Melissa Linkert, Sebastién Besson, Chris Allan, Jason Swedlow | glencoesoftware | Glencoe Software | 2024-08-05 | [Accept](./review_1b.md) | ## Overview From 926adb727b5fe98169a70e10e24d9fb7f5ff5f13 Mon Sep 17 00:00:00 2001 From: Josh Moore Date: Mon, 26 Aug 2024 16:22:18 +0200 Subject: [PATCH 4/4] Move to R6 --- rfc/2/index.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rfc/2/index.md b/rfc/2/index.md index 04c5d0f7..3a914f21 100644 --- a/rfc/2/index.md +++ b/rfc/2/index.md @@ -4,7 +4,7 @@ Adopt the version 3 of Zarr for OME-Zarr. ## Status -This RFC is currently in RFC state (R5). +This RFC is currently in RFC state (R6). | Role | Name | GitHub Handle | Institution | Date | Status | | -------- | ------------------- | --------------------------------------------------- | -------------------------------------------------- | ---------- | ----------------------------------------------------------------------- |