Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masks with Z or T null should apply across all Z or T indices #91

Open
will-moore opened this issue Oct 12, 2021 · 1 comment
Open

Masks with Z or T null should apply across all Z or T indices #91

will-moore opened this issue Oct 12, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@will-moore
Copy link
Member

See #82 (comment)

Currently, if all masks have no Z or T index, the omero zarr masks Image:ID exports a label data block with size-Z or size-T = 1. However, this relies on all other clients to interpret this in the same way that OMERO does (to display that label image across all Z/T indices).
Instead, it it better to export a better representation of how we want the data to appear. If a Mask should apply across all Z or T planes, then we should export a Label that spans all those Z/T planes.

cc @pwalczysko

@sbesson
Copy link
Member

sbesson commented Oct 12, 2021

A couple of additional notes from the discussion of this morning:

  1. the OME model unambiguously specifies empty values of TheZ and/or TheT means the shape should apply to all Z-sections and/or time points

https://www.openmicroscopy.org/Schemas/Documentation/Generated/OME-2016-06/ome_xsd.html#Shape_TheZ
https://www.openmicroscopy.org/Schemas/Documentation/Generated/OME-2016-06/ome_xsd.html#Shape_TheT

  1. I am unaware of any provision in the Zarr specification or the NGFF spec to handle these types of scenarios and re-use existing chunks for other indices

@sbesson sbesson added the bug Something isn't working label Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants
@will-moore @sbesson and others