-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON API support for Annotations #532
Comments
For me the primary concern of using each annotation type in the path is the potential explosion of endpoints both at the top-level as well as each object level.
I think this depends on the decision made above. If we have
An alternative suggestion would be to have N
I had missed this variant using the query parameter. Reading https://omero.readthedocs.io/en/stable/developers/json-api.html#list-images, the response of A few additional comments:
|
See ome/omero-marshal#78 (comment)
and discussion below that.
Endpoints we'd want to support:
api/v0/annotations
for listing all annotationsapi/v0/m/objects/<id>/annotations
for listing child Annotations linked to various objects (projects
,datasets
etc).api/v0/tagannotations
,api/v0/fileannotations
etc. which matches omero object namesapi/v0/annotations?type=file
. which is what's used inwebclient/api/annotations
and could allow multiple types e.g.?type=file&type=tag
(although we don't support this in webclient)./annotations
URLs we'd want?ns=my_namespace
.api/v0/annotations/<id>/annotations/
to list the child annotations linked to parent annotation:id. Alsoapi/v0/annotations/<id>/tagannotations/
etc for listing Tags etc?api/v0/annotations/?annotation=id
to list the parent annotations linked to child annotation:id. Alsoapi/v0/tagannotations/?annotation=id
etc for listing Tags etc.api/v0/objects/?annotation=id
to list the parent objects (projects
,datasets
etc) linked to child annotation:id.Question: do we want to support:
api/v0/annotations/?dataset=123
for listing child Annotations linked to parent Dataset? We do supportapi/v0/images/?dataset=123
for listing child Images of a Dataset, so it's consistent with that, but in the case ofapi/v0/annotations/?annotation=123
we are listing parent annotations, not children, so this might be confusing?!cc @chris-allan @sbesson @joshmoore
The text was updated successfully, but these errors were encountered: