Refactor toggle/fetch JS. #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Manage dereferencer content visibility with css class instead of inline styles. (Addresses omeka/omeka-s#2249) * Condense fetch and toggle into single button. It toggles the content and only fetches on the first click.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manage dereferencer content visibility with css class instead of inline styles. (Addresses omeka/omeka-s#2249)
Previously, the
div.uri-dereferencer-markupis visible on load, even if empty. This causes some themes to display empty containers, creating awkward extra space or empty boxes in some themes. Now the CSS sets this container todisplay: noneby default, then applies visibility by adding the.openCSS class.Condense fetch and toggle into single button.
A single button toggles the content and only fetches dereferencer content on the first click, reducing the amount of markup added to the page.