Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site thumbnail help text #2156

Open
allanaaa opened this issue Feb 28, 2024 · 9 comments
Open

Site thumbnail help text #2156

allanaaa opened this issue Feb 28, 2024 · 9 comments

Comments

@allanaaa
Copy link

When users choose a thumbnail for their site, they choose it from assets or upload a new one.

We should include help text to say that site thumbnails should be square and small (maybe 240x240px maximum) and point out that they will be displayed on the default homepage list-of-sites, and in the "Sites list" page block. The default homepage displays them at 240x240px, while the page block varies by theme but is always smaller than that.

@kimisgold
Copy link
Member

How about

Choose or upload a thumbnail to display with site. Thumbnails should be a uniform aspect ratio. They appear in the public default list of sites view, as well as the "list of sites" page block.

@allanaaa
Copy link
Author

allanaaa commented Apr 9, 2024

I don't think "uniform aspect ratio" means anything.

Choose or upload a thumbnail to display with this site. Thumbnails should be square and small. They appear at a maximum of 240px by 240px in the public default list of sites view, and smaller in the "list of sites" page block.

@zerocrates
Copy link
Member

I think the idea with uniform was that, whatever you choose it should be the same between sites. There isn't really a problem if they're not square, is there?

@allanaaa
Copy link
Author

The only use is square, so why not tell people exactly what they need to know?

This is the user manual version:

Upload a thumbnail for your site, or select one from your installation's assets, which will appear alongside the summary text on the landing page and in the list of sites page block. We recommend using a small square image, no more than 240 by 240 pixels (the largest it will display, on the landing page). You can also set a favicon for your site later.

@zerocrates
Copy link
Member

When you say the only use is square, what do you mean? They're not actually restricted to square as far as I'm aware.

@allanaaa
Copy link
Author

Oh, I thought I saw that in the CSS. Okay, it's "max-width:15rem" (240px) on the homepage, and "max-height:72px" in the list of sites page block.

There are no limits at all on height and width respectively, so you can end up with stuff like this?

Screenshot 2024-04-11 at 11 59 20 Screenshot 2024-04-11 at 12 01 23

We have the overflow set to hidden on the page block, so at least it's not pushing the page width out. But it does mean you can't read any of the text.

@zerocrates
Copy link
Member

I could see an argument for having max restrictions on both dimensions but I'm not overly worried about it, definitely not in a "this needs fixing before release" sense.

@zerocrates
Copy link
Member

In the realm of what the appropriate text here is... do we need anything? The relative lack of restrictions makes me think that pithy guidance isn't so achievable here. Even the 240 pixels aspect is something that would vary based on if you wanted to cater to high DPI viewers, etc.

@allanaaa
Copy link
Author

I suppose not. I think the whole "site thumbnail" concept has always been kind of ambiguous, in terms of where it is actually used. Now that we have favicons too I just think it needs more clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants