Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text commenting flow for a11y #55

Closed
kimisgold opened this issue Dec 3, 2024 · 2 comments
Closed

Text commenting flow for a11y #55

kimisgold opened this issue Dec 3, 2024 · 2 comments
Assignees
Labels

Comments

@kimisgold
Copy link
Member

The ajax branch submits the comment form via ajax and more easily allows screen reader friendly notifications. Please test the following on an item show page:

  • Comment on an item. Navigate to the commenting form via keyboard.
  • Each field on the comment form should be properly labeled and read by the screen reader.
  • When a comment is successfully submitted, the screen reader notifies the user.
  • Submitted comments can be flagged for removal, as well as unflagged. The screen reader should announce the comment state when this happens.
  • Users can reply to comments. Activating the reply link should place the comment form immediately under the reply target, and then focus on the first field of the commenting form.
@katknow
Copy link

katknow commented Jan 8, 2025

This is working for the most part. The only unusual thing I'm finding is that NVDA (not JAWS or VoiceOver) is reading the text fields as ones that autocomplete across browsers, even though this does not seem to be true. Additionally, NVDA is referring to the comment area as an applicaton but not specifically a text field like JAWS or VoiceOver. I don't know if that is something fixable or if it is software dependent.

@kimisgold
Copy link
Member Author

This seems to be expected behavior for NVDA, because the browser can provide suggestions for those fields. The comment area is also considered an application because tinymce is acting a rich text editor. I think we're good here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants