Improvement: Fix DeepFilterNetCommandBuilder::setInputFile() limitation
#52
Labels
core
Media processing component, the core C++ binary.
help wanted
Extra attention is needed
improvement
Improve existing functionality
Comments
omeryusufyagci
added
help wanted
omeryusufyagci
added a commit
that referenced
this issue
Oct 22, 2024
Added a method to pass --compensate-delay flag which is required to ensure the filtered audio remains in sync with the source media. Minor refactor for general consistency Added doxy docs to the header Discovered a user-side problem; see #52 for details
omeryusufyagci
changed the title
DeepFilterNetCommandBuilder::setInputFile() can be called flexiblyDeepFilterNetCommandBuilder::setInputFile() limitation
|
I saw this when making test cases. One way is to store all the arguments first and calling addArgument or addFlag in required sequence in build function. or adding another function which adds the flag in front of the command instead of pushing back. can be useful in many cases like command name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Due to a limitation of the underlying model, we cannot pass an input file flag (for OS calling).
This causes an issue where the user has to know when to call the
setInputFile()method first, which diverges from the builder pattern, and is just not nice.We need a solution for this without sacrificing the const-correctness and diverging from the pattern.
More details in the
DeepFilterCommandBuilder.hfile.The text was updated successfully, but these errors were encountered: