Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Add Logging Mechanism for MediaProcessor #7

Open
omeryusufyagci opened this issue Sep 29, 2024 · 12 comments
Open

Improvement: Add Logging Mechanism for MediaProcessor #7

omeryusufyagci opened this issue Sep 29, 2024 · 12 comments
Assignees
Labels
good first issue Good for newcomers hacktoberfest This issue is eligible for Hacktoberfest contributions help wanted Extra attention is needed improvement Improve existing functionality

Comments

@omeryusufyagci
Copy link
Owner

Introduce a proper logger for the MediaProcessor.

Objective:

  • Add a new logger, e.g. https://github.com/gabime/spdlog, and replace the existing cout/cerr messages with the logger.
  • Explore and improve overall logging on the C++ side.
@omeryusufyagci omeryusufyagci added help wanted Extra attention is needed good first issue Good for newcomers improvement Improve existing functionality hacktoberfest This issue is eligible for Hacktoberfest contributions labels Sep 29, 2024
@meet0806
Copy link

meet0806 commented Oct 1, 2024

@omeryusufyagci I would like to work on this issue.

@omeryusufyagci
Copy link
Owner Author

Hi @meet0806, thanks for your interest!

I've assigned the issue to you. I noticed you've already forked the repo. I just pushed a relatively large update to both the README and CONTRIBUTING files, which should help you get started. I'd recommend pulling the latest changes from upstream before starting.

@meet0806
Copy link

@omeryusufyagci I have made some changes to my local env. How can I test it ??

@omeryusufyagci
Copy link
Owner Author

Hi @meet0806,

@omeryusufyagci I have made some changes to my local env. How can I test it ??

From project root you should be able to do MediaProcessor/build/MediaProcessor uploads/input_video.mp4

If you don't have a video in the uploads, you can start the app again at project root via python3 app.py, use the UI to download video.

Does this help?

@meet0806
Copy link

@omeryusufyagci
image
it shows that an error occurred

@omeryusufyagci
Copy link
Owner Author

Have you pulled from upstream already? In any case, main has always been stable so this is surprising. Any logs on the web console (F12) or on the backend server? can you try to run it through the docker and try again? If you can share some details and if your fork is up to date, I can try to have a look, but please first pull from main.

Thanks for checking and letting me know!

@omeryusufyagci
Copy link
Owner Author

omeryusufyagci commented Oct 17, 2024

Hey @meet0806, today this exchange randomly came to me ! I wanted to ask if you have verified your ffmpeg path on the config.json file at the project root? That could also be causing this. If you're on Windows, you should definitely update the path, on Unix it should be ok.

@meet0806
Copy link

Hey @meet0806, today this exchange randomly came to me ! I wanted to ask if you have verified your ffmpeg path on the config.json file at the project root? That could also be causing this. If you're on Windows, you should definitely update the path, on Unix it should be ok.

Ok, I will check that

@omeryusufyagci
Copy link
Owner Author

Hi @meet0806, do you have any news on this? Do you have the same problem when you run it with docker? Would be very helpful if we can introduce the logger soon. Please let me know in case you need any help.

@meet0806
Copy link

meet0806 commented Oct 23, 2024

Hii @omeryusufyagci, (used docker to run) I tried to run it before adding spdlog it was working. but after changes, it giving the same error
image
image

@omeryusufyagci
Copy link
Owner Author

Hii @omeryusufyagci, (used docker to run) I tried to run it before adding spdlog it was working. but after changes, it giving the same error image image

@meet0806, it's difficult to guess from here what went wrong. Could you run the MediaProcessor directly which would allow you to see the logs?

# from project root (edit to suit if on Windows)
MediaProcessor/build/MediaProcessor uploads/<input_video.ext>

Also please ensure your branch is not outdated to facilitate troubleshooting this easily.
Please let me know what you see

@meet0806
Copy link

logs will look like this
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest This issue is eligible for Hacktoberfest contributions help wanted Extra attention is needed improvement Improve existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants