Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Explore supporting user-provided audio tracks #80

Open
omeryusufyagci opened this issue Nov 26, 2024 · 2 comments
Open

Feature: Explore supporting user-provided audio tracks #80

omeryusufyagci opened this issue Nov 26, 2024 · 2 comments
Labels
core Media processing component, the core C++ binary. feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@omeryusufyagci
Copy link
Owner

This is a suggestion from the community that asks us to support user-provided audio tracks as replacement to filtered content.

As a first step, we could try to provide support for adding audio tracks on the filtered media and see where we can go from there.

Could be a good first issue for anyone interested in this and is comfortable working with C++ (see MediaProcessor), as it's mostly a standalone feature that shouldn't be too difficult to integrate with the existing program.

@omeryusufyagci omeryusufyagci added feature New feature or request help wanted Extra attention is needed good first issue Good for newcomers core Media processing component, the core C++ binary. labels Nov 26, 2024
@omeryusufyagci omeryusufyagci pinned this issue Nov 26, 2024
@Rushi1109
Copy link

Rushi1109 commented Dec 25, 2024

Can you elaborate this issue further? What do you mean by user-provided audio tracks? What should be the input and output for this feature?

@omeryusufyagci
Copy link
Owner Author

Hi @Rushi1109, this is an interesting one really!

It's about applying an external audio track on top of a source file.
So, imagine the user has a video they want to filter, and then they have a secondary audio track, like some ambient sounds to apply on top of the cleaned audio. This would make it possible to record a conversation such as a podcast in a noisy environment, clean it, and even add a custom audio track as the new background sound.

In terms of implementation, we should provide a new pipeline in the processing engine for this, and not assume that will only be invoked after filtering, i.e. a user may want to use this functionality simply to append a new audio track without filtering the original media file.

Please let me know if you have any further questions, and if you'd like me to assign this to you. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Media processing component, the core C++ binary. feature New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants