Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update IDL #19

Open
mitza-oci opened this issue Jul 22, 2024 · 3 comments · May be fixed by #20
Open

Update IDL #19

mitza-oci opened this issue Jul 22, 2024 · 3 comments · May be fixed by #20

Comments

@mitza-oci
Copy link
Contributor

Would it work for everyone if we changed the contents of the IDL file in this repo to match https://github.com/omg-dds/dds-rtps/blob/master/srcCxx/shape.idl ? It might require a PR for each implementation to adjust their build settings / configuration -- or it might just work out of the box.

@colmenero @JaimeMartin @ClarkTucker @ornulfs
@colmenero
Copy link
Contributor

I'm ok with changing the contents of the IDL file to match the one in the dds-rtps repository.

To avoid breaking the state of the repository, how about we create an "epic" branch with the idl modification and all vendors test/implement based on that branch? We can merge it to master when ready.

@mitza-oci
Copy link
Contributor Author

Yes, that sounds good. I'll start a new branch after #16 and #17 are merged so we're at the same starting point.

@ClarkTucker
Copy link
Contributor

Sounds good to me.

@mitza-oci mitza-oci linked a pull request Jul 30, 2024 that will close this issue
Updated IDL to match the file used in the dds-rtps repository #20
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated IDL to match the file used in the dds-rtps repository omg-dds/dds-security
3 participants
@colmenero @ClarkTucker @mitza-oci