Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider removing exit_finality_margin from watcher #1561

Open
InoMurko opened this issue Jun 2, 2020 · 0 comments
Open

consider removing exit_finality_margin from watcher #1561

InoMurko opened this issue Jun 2, 2020 · 0 comments

Comments

@InoMurko
Copy link
Contributor

InoMurko commented Jun 2, 2020

exit_finality_margin: 12,

It seems redundant because they all follow the :depositor process

exit_processor: [waits_for: :depositor, finality_margin: finality_margin],
exit_finalizer: [
waits_for: [:depositor, :block_getter, :exit_processor],
finality_margin: finality_margin
],
exit_challenger: [waits_for: :exit_processor, finality_margin: finality_margin],
in_flight_exit_processor: [waits_for: :depositor, finality_margin: finality_margin],
piggyback_processor: [waits_for: :in_flight_exit_processor, finality_margin: finality_margin],
competitor_processor: [waits_for: :in_flight_exit_processor, finality_margin: finality_margin],
challenges_responds_processor: [waits_for: :competitor_processor, finality_margin: finality_margin],
piggyback_challenges_processor: [waits_for: :piggyback_processor, finality_margin: finality_margin],
ife_exit_finalizer: [
waits_for: [:depositor, :block_getter, :in_flight_exit_processor, :piggyback_processor],
finality_margin: finality_margin
]

:depositor margin is 10, exit processor finality margin is 12 - what does it really give us? Also, events are fetched by the depositor with margin 10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant