-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
omniscient on top of vtree + vdom #49
Comments
I'd be willing to give it a shot, as it maybe enable me to omniscient for the a next project. |
I just need to know if project owners will be interested in taking patches to enable this. |
This seems like it should be an adapter that can be passed to |
@phated sure passing something to |
As I mentioned on Gitter, as there are a few things that's "missing" from usage with virtual-dom and React, I don't think Omniscient is/should be quite capable to have this as a drop-in replacement, but I think a good approach would be to have a separate module patching the differences between React and virtual-dom, and this can be passed as an "modifier" in This module would need something like: Mixin support, patching I think it makes sense having this outside core, to avoid many ifs, it nots and thens and all other switch cases. As maybe 95% of the cases with Omniscient would use React. |
I'd say have at it! I'm also for a something separate, but pluggable, and a couple of more hooks in omniscient in contrast to a complete rewrite. But I reckon some changes are needed. Why don't you have a go and see what path it takes |
Someone had concerns on depending on a specific virtual dom library, and was able to create something that would compile to various targets: |
I'd be like to get omniscient to a point where it can be used with vtree+ vdom instead of react for few reasons:
The text was updated successfully, but these errors were encountered: