Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCLomatic #2032] Add test case for dpct::argmin and dpct::argmax #724

Merged

Conversation

mmichel11
Copy link
Contributor

@mmichel11 mmichel11 commented Jun 4, 2024

This PR adds a test case for oneapi-src/SYCLomatic#2032. The CI in this PR will fail until the base SYCLomatic PR is merged.

For dpct::argmin and dpct::argmax we test the following cases (tested through reductions with the functor):

  • A case where all key_value_pair objects have unique values. The lowest / greatest key_value_pair based on the value is returned.
  • A case where all key_value_pair objects have the same values. The lowest key_value_pair with the lowest key is returned.

Copy link

@timmiesmith timmiesmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timmiesmith
Copy link

The linux-test-help_function-cpu check will pass when oneapi-src/SYCLomatic#2032 is merged providing the definition of the functions the new test is checking.

Signed-off-by: Matthew Michel <[email protected]>
Copy link
Contributor

@danhoeflinger danhoeflinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhimingwang36 zhimingwang36 merged commit b6e7d49 into oneapi-src:SYCLomatic Jun 25, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants