Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory pooling issue in HIP adapter #1479

Open
igchor opened this issue Mar 27, 2024 · 0 comments
Open

Memory pooling issue in HIP adapter #1479

igchor opened this issue Mar 27, 2024 · 0 comments
Labels
bug Something isn't working hip HIP adapter specific issues

Comments

@igchor
Copy link
Member

igchor commented Mar 27, 2024

HIP adapter has an ifdef to enable pooling support in urUSMPoolCreate:

unified-runtime/source/adapters/hip/usm.cpp

Line 388 in 4aeb55e

#ifdef UMF_ENABLE_POOL_TRACKING
The define, however is never set which means we do not test HIP with pooling enabled at all.

I tried setting UMF_ENABLE_POOL_TRACKING but this results in segfault in tests:

# ./bin/test-sum

...

[----------] 12 tests from urUSMHostAllocTest
[ RUN      ] urUSMHostAllocTest.Success/AMD_HIP_BACKEND___AMD_Radeon_RX_6800_XT___UsePoolEnabled
Segmentation fault (core dumped)
@igchor igchor added bug Something isn't working hip HIP adapter specific issues labels Mar 27, 2024
frasercrmck added a commit to frasercrmck/unified-runtime that referenced this issue May 30, 2024
@frasercrmck
[HIP] Enable support for USM memory pools
fbaf222 
Copies code for the pool descriptor from the CUDA adapter.

Fixes oneapi-src#1479.
@frasercrmck frasercrmck mentioned this issue May 30, 2024
Closed
frasercrmck added a commit to frasercrmck/unified-runtime that referenced this issue Jun 4, 2024
@frasercrmck
[HIP] Enable support for USM memory pools
5693416 
Copies code for the pool descriptor from the CUDA adapter.

Fixes oneapi-src#1479.
frasercrmck added a commit to frasercrmck/unified-runtime that referenced this issue Jun 6, 2024
@frasercrmck
[HIP] Enable support for USM memory pools in HIP 6+
beba2d5 
Copies code for the pool descriptor from the CUDA adapter.

Fixes oneapi-src#1479.
frasercrmck added a commit to frasercrmck/unified-runtime that referenced this issue Jun 11, 2024
@frasercrmck
[HIP] Enable support for USM memory pools in HIP 6+
818adde 
Copies code for the pool descriptor from the CUDA adapter.

Fixes oneapi-src#1479.
frasercrmck added a commit to frasercrmck/unified-runtime that referenced this issue Jun 11, 2024
@frasercrmck
[HIP] Enable support for USM memory pools in HIP 6+
e6b2023 
Copies code for the pool descriptor from the CUDA adapter.

Fixes oneapi-src#1479.
frasercrmck added a commit to frasercrmck/unified-runtime that referenced this issue Jun 13, 2024
@frasercrmck
[HIP] Enable support for USM memory pools in HIP 6+
0fa7d4e 
Copies code for the pool descriptor from the CUDA adapter.

Fixes oneapi-src#1479.
frasercrmck added a commit to frasercrmck/unified-runtime that referenced this issue Jun 13, 2024
@frasercrmck
[HIP] Enable support for USM memory pools in HIP 6+
014d08e 
Copies code for the pool descriptor from the CUDA adapter.

Fixes oneapi-src#1479.
@frasercrmck frasercrmck mentioned this issue Oct 22, 2024
Closed
frasercrmck added a commit to frasercrmck/unified-runtime that referenced this issue Oct 28, 2024
@frasercrmck
[HIP] Enable support for USM memory pools
7a6c44a 
Copies code for the pool descriptor from the CUDA adapter.

Fixes oneapi-src#1479.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working hip HIP adapter specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[HIP] Enable support for USM memory pools frasercrmck/unified-runtime
1 participant
@igchor