Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No timeout defined for Command Extractor #621

Closed
qkaiser opened this issue Jun 23, 2023 · 0 comments · Fixed by #622
Closed

No timeout defined for Command Extractor #621

qkaiser opened this issue Jun 23, 2023 · 0 comments · Fixed by #622
Assignees
Labels
bug Something isn't working

Comments

@qkaiser
Copy link
Contributor

qkaiser commented Jun 23, 2023

The framework calls external extractors without setting an explicit execution timeout. If an external extractors goes haywire (e.g. debugfs getting into an endless loop), unblob may never finish.

After an internal discussion, we decided to set a timeout value that is high enough not to block long running execution such as extraction of large disk images, but small enough to make sure unblob finish its execution at some point.

We agreed to a 12 hours timeout 🤓

@qkaiser qkaiser added the bug Something isn't working label Jun 23, 2023
@qkaiser qkaiser self-assigned this Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant