Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve issues found during Cadence integration for Atree inlining and deduplication #351

Closed
11 tasks
fxamacker opened this issue Oct 18, 2023 · 1 comment
Closed
11 tasks

Resolve issues found during Cadence integration for Atree inlining and deduplication #351

fxamacker opened this issue Oct 18, 2023 · 1 comment
Assignees
@fxamacker
Labels
bug Something isn't working enhancement New feature or request improvement

Comments

@fxamacker
Copy link
Member

I ran into some integration issues while updating onflow/cadence to use Atree PR #342 and #345. We should:

  • Rename TypeInfo.ID() to TypeInfo.Identifier()
  • Change array encoding error type
  • Change map encoding error type
  • Add InlinedExtraData interface
  • Add ContainerStorable interface
  • Rename Encode to EncodeSlab
  • Encode inlined map as map key
  • Add test verification for compact map serialization
  • Add more tests for decoded array/map
  • Export EncodeStorableAsElement()
  • Add ContainerStorable.HasPointer()

More details will be in the PR that closes this issue.
@fxamacker fxamacker added bug Something isn't working enhancement New feature or request improvement labels Oct 18, 2023
@fxamacker fxamacker self-assigned this Oct 18, 2023
@fxamacker fxamacker mentioned this issue Oct 18, 2023
Merged
17 tasks
@fxamacker
Copy link
Member Author

fxamacker commented Nov 1, 2023 •
edited
Loading

This is closed by #352 and onflow/cadence#2920.

For more info, see onflow/cadence#2882.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fxamacker fxamacker

Labels
bug Something isn't working enhancement New feature or request improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fxamacker