Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more integration tests #353

Closed
fxamacker opened this issue Oct 19, 2023 · 1 comment
Closed

Add more integration tests #353

fxamacker opened this issue Oct 19, 2023 · 1 comment
Assignees
@fxamacker
Labels
tests

Comments

@fxamacker
Copy link
Member

Issue To Be Solved

More integration tests should be added for changes introduced by PR #342, #345, and #352.

Some tests will be added at onflow/cadence#2882. However, other tests can be added here.

Suggested Solution

Add more tests.
@fxamacker fxamacker self-assigned this Oct 19, 2023
@fxamacker fxamacker mentioned this issue Nov 1, 2023
Closed
11 tasks
@fxamacker
Copy link
Member Author

Closing for same reason cited by Jan at onflow/cadence#2837 (comment)

what we have now is sufficient after we have smoke tests running successfully.

Also, we can reopen or create new issue if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fxamacker fxamacker

Labels
tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fxamacker