Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the migration feature that filters unreferenced slabs #395

Closed
fxamacker opened this issue Apr 25, 2024 · 0 comments
Closed

Fix the migration feature that filters unreferenced slabs #395

fxamacker opened this issue Apr 25, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@fxamacker
Copy link
Member

fxamacker commented Apr 25, 2024

Recently, migration programs in onflow/flow-go added a flag to filter out old unreferenced slabs and onflow/atree added some functions to support that. However, some of the old unreferenced slabs are not filtered.

This issue only affects this new migration feature in onflow/flow-go:

More info:

Suggestion

After looking into this today, it is clear that traversal needs to go deeper to handle nested storage id inside another storable such as Cadence SomeValue. Update the code to do this and add more tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant