Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for EVM on Flow #28825

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

nialexsan
Copy link

@nialexsan nialexsan commented Nov 29, 2024

Description

Adding support for EVM on Flow

Flow blockchain supports EVM as of September 2024
this PR adds EVM on Flow to the list of additional networks so users can easily add it to their network list

Open in GitHub Codespaces

Related issues

Fixes: onflow/docs#1006

Manual testing steps

  1. build the project with yarn dist and yarn dist:mv2
  2. add the local build to a chrome based browser or a firefox based browser
  3. open the Metamask extension
  4. open switch network interface
  5. there should be an EVM on Flow Mainnet chain in the list
  6. clicking on it should successfully add it to the list of networks

Screenshots/Recordings

Before

Screenshot 2024-11-29 at 16 04 26

After

Screenshot 2024-11-29 at 15 53 57

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@nialexsan nialexsan requested a review from a team as a code owner November 29, 2024 21:12
@nialexsan nialexsan marked this pull request as draft November 29, 2024 21:12
Copy link
Contributor

github-actions bot commented Nov 29, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@nialexsan
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@nialexsan nialexsan marked this pull request as ready for review December 2, 2024 20:31
@nialexsan nialexsan requested a review from a team as a code owner December 3, 2024 17:52
@nialexsan nialexsan requested a review from a team as a code owner December 9, 2024 19:37
@dbrans dbrans removed the request for review from a team December 12, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a PR to Metamask with Flow Blockchain
2 participants