Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fee calculation implementation & test coverage #31

Closed
sisyphusSmiling opened this issue Apr 13, 2024 · 0 comments · Fixed by #32
Closed

Add fee calculation implementation & test coverage #31

sisyphusSmiling opened this issue Apr 13, 2024 · 0 comments · Fixed by #32

Comments

@sisyphusSmiling
Copy link
Contributor

Issue To Be Solved

The bridge will need to charge fees for the sake of funding account storage and to prevent spam. Fees are currently broken down to cover the following:

  • onboarding assets: deploying contracts and initializing escrow to lock assets
  • base fee: a flat rate fee included for every bridge request
  • storage rate: the cost basis for each stored byte

Suggest A Solution

The fee to bridge an asset should be at least as much as it costs the bridge account to escrow the asset, if it needs to be escrowed at all.

This issue relates to the functionality of setting fees and validating bridging behavior when those fees are set, not necessarily the economics of the fee amount in question. In addition to fee feature integration, we will also need to consider and test the impact of the fee rates we choose to set at scale and ensure the final amounts safeguards against potential storage ddos vectors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant