Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace EVM.BridgeRouter interface with resource definition #60

Closed
sisyphusSmiling opened this issue Apr 30, 2024 · 1 comment
Closed
Assignees

Comments

@sisyphusSmiling
Copy link
Contributor

Issue To Be Solved

The purpose of the BridgeRouter construct was to both decouple the routing of bridge requests from core EVM functionality and enable an extensible pathway for bridge replacements and routing redirects. Currently, this construct is an interface which is implemented in bridge-related contracts; however, when a new set of bridge contracts are deployed, the underlying BridgeRouter type also changes. This presents a problem when redirecting to a new set of bridge contracts as the new contracts cannot be fully decoupled from the old ones - the initial version's router is used to contain any successive BridgeAccessor Capability.

Suggest A Solution

Replace the BridgeRouter interface definition with one of a resource in the EVM contract. Alternatively, the BridgeRouter interface could remain but the implementation and initialization defined in a new contract deployed to the EVM account.

@sisyphusSmiling
Copy link
Contributor Author

Closing as will be moving forward with contracts as-is

@github-project-automation github-project-automation bot moved this from 🏗 In Progress to ✅ Done in 🌊 Flow 4D Aug 29, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in FlowEVM Bridge Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant