Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code accessing contract fields - re: FLIP 277 #93

Closed
sisyphusSmiling opened this issue Jun 28, 2024 · 0 comments · Fixed by #94
Closed

Update code accessing contract fields - re: FLIP 277 #93

sisyphusSmiling opened this issue Jun 28, 2024 · 0 comments · Fixed by #94
Assignees
Labels
Bug Something isn't working

Comments

@sisyphusSmiling
Copy link
Contributor

sisyphusSmiling commented Jun 28, 2024

Issue To Be Solved

Recent updates to how contracts are imported (see FLIP 277) and their values are accessed have impacted a number of transactions and scripts in this repo.

Suggest A Solution

Uncover and refactor the affected transactions and scripts. Will also need to determine if this new change affects any contract syntax as a number of contract fields are accessed between bridge contracts.

🚫 Testing refactors and assessing required contract syntax changes is blocked for the moment until we get an updated CLI pre-release running Cadence v1.0.0-preview.35 as errors that might occur may only emerge at runtime. <- unblocked by release of Flow CLI v1.21.0-cadence-v1.0.0-preview.28

Context

Found while deploying and configuring the bridge on latest Crescendo network.
Related Discord thread

@sisyphusSmiling sisyphusSmiling added the Bug Something isn't working label Jun 28, 2024
@sisyphusSmiling sisyphusSmiling self-assigned this Jun 28, 2024
@sisyphusSmiling sisyphusSmiling moved this to ✋ Blocked in 🌊 Flow 4D Jun 28, 2024
@sisyphusSmiling sisyphusSmiling moved this from Todo to Blocked in FlowEVM Bridge Jun 28, 2024
@sisyphusSmiling sisyphusSmiling moved this from ✋ Blocked to 🏗 In Progress in 🌊 Flow 4D Jun 28, 2024
@sisyphusSmiling sisyphusSmiling moved this from Blocked to In Progress in FlowEVM Bridge Jun 28, 2024
@sisyphusSmiling sisyphusSmiling moved this from 🏗 In Progress to 👀 In Review in 🌊 Flow 4D Jun 28, 2024
@sisyphusSmiling sisyphusSmiling moved this from In Progress to In Review in FlowEVM Bridge Jun 28, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in FlowEVM Bridge Jul 1, 2024
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in 🌊 Flow 4D Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Status: Done
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant